Homework 2 forum

Possible Error in TestGossiper_Download_Parallel_Multiple

 
Picture of Sacha Adrien Bartholmé
Possible Error in TestGossiper_Download_Parallel_Multiple
by Sacha Adrien Bartholmé - Tuesday, 10 November 2020, 15:33
 

There is a possible mistake in this test that made my tests fail. The line

nB.gossiper.AddRoute(nB.id, nB.addr) // B --> A

Should be replaced by 

nB.gossiper.AddRoute(nA.id, nA.addr) // B --> A
 
Permalink | Reply
Picture of Sacha Adrien Bartholmé
Re: Possible Error in TestGossiper_Download_Parallel_Multiple
by Sacha Adrien Bartholmé - Tuesday, 10 November 2020, 15:46
 

Never mind, apparently it has already been fixed.

 
Permalink | Show parent | Reply
Picture of Clément Luc Irénée Blaudeau
Re: Possible Error in TestGossiper_Download_Parallel_Multiple
by Clément Luc Irénée Blaudeau - Saturday, 14 November 2020, 11:58
 

I actually have the exact same issue. Where did the fix came from ? I pulled the master branch of gitlab but it did not change anything

 
Permalink | Show parent | Reply
profile
Re: Possible Error in TestGossiper_Download_Parallel_Multiple
by Kirill Nikitin - Saturday, 14 November 2020, 12:28
 

Hi,

The issue was fixed with commit 302f477e67b6d15ec980153507b85d192cf0cf46 when we also added the integration tests. I have checked and I can see it on your master branch.

Or are you referring to some similar issue in another test?

Kirill

 
Permalink | Show parent | Reply