Homework 2 forum

Question about TestGossiper_Search_Query_Keywords_Complex

 
Nutzerbild von Reka Inovan
Question about TestGossiper_Search_Query_Keywords_Complex
von Reka Inovan - Dienstag, 3. November 2020, 18:54
 

Hi,

My implementation kept failing at TestGossiper_Search_Query_Keywords_Complex.
From my understanding, in that test, node A sends a search request 5 times, with 2 seconds in-between each search request.
There are 3 accessible nodes with the searched file in the network.

I would expect that node A will receives 15 search replies (if we assumed the transmissions are perfectly reliable).
But in line 984 of gossiper_test.go, there is an assertion that said there should be exactly 3 search reply messages received.

I am confused why we expect exactly 3 search reply message, I might be missing something obvious here.

profile
Re: Question about TestGossiper_Search_Query_Keywords_Complex
von Kirill Nikitin - Mittwoch, 4. November 2020, 14:02
 

Hi,

You are right, we have made an error there. Node A is supposed to send the request only once and actually with a higher budget to be sure that all the three replies are received. Thanks for raising the issue! Following it, we have spotted a couple other issues with the search testing. 

We will push updates to the tests today.

Thanks,

Kirill

Nutzerbild von Reka Inovan
Re: Question about TestGossiper_Search_Query_Keywords_Complex
von Reka Inovan - Mittwoch, 4. November 2020, 15:48
 

Great! Thanks for the quick fixes there.

Best,
Reka