Homework 1 forum

Possible bug in TestGossiper_Topo3_3Nodes_AntiEntropy

 
Picture of Francesco Intoci
Possible bug in TestGossiper_Topo3_3Nodes_AntiEntropy
by Francesco Intoci - Saturday, 24 October 2020, 19:06
 

Hello, I think I have found a bug in the mentioned test. The test verifies that NodeA does not receive any message whose origin is peerA, but when the test defines msgRecN1 with the 'streamIncomingGossips' function, a Callback is defined. In the project specification it is stated that every time a peer receives a new message(from another gossiper or from the client), it must call the callback. But in the second case the rumor message will have as origin the node itself, making the test fail. I don't know if I am wrong, please let me know.

Regards,

Francesco

Picture of Francesco Intoci
Re: Possible bug in TestGossiper_Topo3_3Nodes_AntiEntropy
by Francesco Intoci - Saturday, 24 October 2020, 19:21
 

Hi again,

Maybe it is not a bug and I haven't understood correctly the project specs. Do we need to call g.Callback when receiving  a message from the client?

Picture of Bastien Wermeille
Re: Possible bug in TestGossiper_Topo3_3Nodes_AntiEntropy
by Bastien Wermeille - Saturday, 24 October 2020, 23:31
 

Hello,

From what I have understood, we do not have to call the callback. The callback is for the messages which are not from the client and allow to display them directly on the web interface. The messages coming from the client are already displayed.

Picture of Francesco Intoci
Re: Possible bug in TestGossiper_Topo3_3Nodes_AntiEntropy
by Francesco Intoci - Sunday, 25 October 2020, 11:54
 

Hi,

Yes it makes sense. Thanks!